Compatibility with rescript 12 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing |
glennsl
reviewed
Aug 6, 2025
package.json
Outdated
Comment on lines
6
to
7
| "build": "rescript legacy build -with-deps", | ||
| "start": "rescript legacy build -w -with-deps", |
There was a problem hiding this comment.
@glennsl it will. I just scoped the changes while working on updating my work projects. I've updated the commands, I tested them, and they work fine. fmt would re-format the project, but I decided not to stage the changes. I can do it in a separate commit or a PR if you like
There was a problem hiding this comment.
Nice. Thanks! Yes, a separate commit for the formatting changes would be nice.
|
Any objections to not merging this until 12 is out? Anyone needing it for testing can just point to this branch, I'm thinking. |
|
I have no problems with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi @glennsl! Thanks for the library, I like it. Rescript 12 beta.1 has been released recently. In this PR, I updated some stdlib calls and renamed bsconfig.json to rescript.json.
Feel free to merge or close it if you have plans to make things differently.